Skip to content

Move SAML/OIDC web handlers to enterprise repository#17459

Merged
camscale merged 2 commits intomasterfrom
camh/remove-ent-sso-api
Oct 25, 2022
Merged

Move SAML/OIDC web handlers to enterprise repository#17459
camscale merged 2 commits intomasterfrom
camh/remove-ent-sso-api

Conversation

@camscale
Copy link
Copy Markdown
Contributor

@camscale camscale commented Oct 17, 2022

Remove the SAML and OIDC web handlers from this repository as they have been added to the enterprise repository. The SAML and OIDC connectors are not available in the OSS edition and connectors of these types could not be created.

This change should not have any effect on existing OSS deployments.

Issue: https://github.com/gravitational/teleport.e/issues/525


Note: This PR should be reviewed in conjunction with https://github.com/gravitational/teleport.e/pull/562, the corresponding PR that adds this code to the enterprise repository. That PR should be merged first, followed by this one in short order.

@camscale camscale marked this pull request as draft October 17, 2022 05:56
@camscale camscale force-pushed the camh/remove-ent-sso-api branch from 6fa11f2 to 9391cfe Compare October 18, 2022 04:22
@camscale camscale changed the base branch from camh/export-lib-web-tests to camh/export-sso October 18, 2022 04:27
Base automatically changed from camh/export-sso to master October 19, 2022 03:33
@camscale camscale force-pushed the camh/remove-ent-sso-api branch 4 times, most recently from 3baefdf to 79c26bb Compare October 19, 2022 05:57
@camscale camscale marked this pull request as ready for review October 19, 2022 06:03
@github-actions github-actions Bot requested review from Joerger and jakule October 19, 2022 06:03
Copy link
Copy Markdown
Contributor

@tobiaszheller tobiaszheller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions github-actions Bot removed request for Joerger and jakule October 19, 2022 13:43
@camscale camscale force-pushed the camh/remove-ent-sso-api branch 3 times, most recently from 50e4f45 to 85128cb Compare October 25, 2022 05:27
Remove the SAML and OIDC web handlers from this repository as they have
been added to the enterprise repository. The SAML and OIDC connectors
are not available in the OSS edition and connectors of these types could
not be created.

This change should not have any effect on existing OSS deployments.

NOTE: This commit cannot be merged until the corresponding commit in the
enterprise repository is merged and the commit hash of the `e` submodule
updated to correspond to that of the merged commit in the enterprise
repository.
@camscale camscale force-pushed the camh/remove-ent-sso-api branch from ad2dacc to 8e8f641 Compare October 25, 2022 07:18
@camscale camscale enabled auto-merge (squash) October 25, 2022 07:19
@camscale camscale merged commit 034ac90 into master Oct 25, 2022
@camscale camscale deleted the camh/remove-ent-sso-api branch October 25, 2022 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants